-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨use legacy successors, support skips and skipRange #743
✨use legacy successors, support skips and skipRange #743
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
a22b113
to
633f86e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #743 +/- ##
==========================================
+ Coverage 63.50% 63.81% +0.30%
==========================================
Files 22 22
Lines 1403 1415 +12
==========================================
+ Hits 891 903 +12
Misses 459 459
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
} | ||
if candidateBundleEntry.SkipRange != "" { | ||
installedBundleVersion, _ := installedBundle.Version() | ||
skipRange, _ := bsemver.ParseRange(candidateBundleEntry.SkipRange) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The difference between blang semver and masterminds semver import aliases is so little that overlooking the subtlety is really easy to do.
Your code is fine, though I can't help but wonder though when someone will 'cross the streams' and we'll miss it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah agreed. Perhaps we should think about adding some wrappers that obviate the subtlety?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Solves #54 |
Description
Reviewer Checklist